pgsql-server: Fix a number of places where brittle data structures or

[Tom Lane]

Log Message:
-----------
Fix a number of places where brittle data structures or overly strong
Asserts would lead to a server core dump if an error occurred while
trying to abort a failed subtransaction (thereby leading to re-execution
of whatever parts of AbortSubTransaction had already run). This of course
does not prevent such an error from creating an infinite loop, but at
least we don't make the situation worse. Responds to an open item on
the subtransactions to-do list.

Modified Files:
--------------
pgsql-server/src/backend/commands:
async.c (r1.115 -> r1.116)
(http://developer.postgresql.org/cvsweb.cgi/pgsql-server/src/backend/commands/async.c.diff?r1=1.115&r2=1.116)
trigger.c (r1.168 -> r1.169)
(http://developer.postgresql.org/cvsweb.cgi/pgsql-server/src/backend/commands/trigger.c.diff?r1=1.168&r2=1.169)
pgsql-server/src/backend/storage/ipc:
sinval.c (r1.72 -> r1.73)
(http://developer.postgresql.org/cvsweb.cgi/pgsql-server/src/backend/storage/ipc/sinval.c.diff?r1=1.72&r2=1.73)
pgsql-server/src/backend/utils/cache:
inval.c (r1.66 -> r1.67)
(http://developer.postgresql.org/cvsweb.cgi/pgsql-server/src/backend/utils/cache/inval.c.diff?r1=1.66&r2=1.67)

---------------------------(end of broadcast)---------------------------
TIP 9: the planner will ignore your desire to choose an index scan if your
joining column's datatypes do not match

[Robert Treat]

Post by Tom Lane
-----------
Fix a number of places where brittle data structures or overly strong
Asserts would lead to a server core dump if an error occurred while
trying to abort a failed subtransaction (thereby leading to re-execution
of whatever parts of AbortSubTransaction had already run). This of course
does not prevent such an error from creating an infinite loop, but at
least we don't make the situation worse. Responds to an open item on
the subtransactions to-do list.

Does that eliminate the following from the open items list?

resolve issues with pg_subtrans and pg_clog re: WAL-logging and fsync /
determine proper crash recovery/logging for pg_subtrans

[Tom Lane]

Post by Robert Treat

Post by Tom Lane
Fix a number of places where brittle data structures or overly strong
Asserts would lead to a server core dump if an error occurred while
trying to abort a failed subtransaction

Does that eliminate the following from the open items list?
resolve issues with pg_subtrans and pg_clog re: WAL-logging and fsync /
determine proper crash recovery/logging for pg_subtrans

No, but we dealt with that stuff two weeks ago. Not sure why it's still
on the open-issues list.

regards, tom lane

---------------------------(end of broadcast)---------------------------
TIP 3: if posting/reading through Usenet, please send an appropriate
subscribe-nomail command to ***@postgresql.org so that your
message can get through to the mailing list cleanly

[Bruce Momjian]

Post by Tom Lane

Post by Robert Treat

Post by Tom Lane
Fix a number of places where brittle data structures or overly strong
Asserts would lead to a server core dump if an error occurred while
trying to abort a failed subtransaction

Does that eliminate the following from the open items list?
resolve issues with pg_subtrans and pg_clog re: WAL-logging and fsync /
determine proper crash recovery/logging for pg_subtrans

No, but we dealt with that stuff two weeks ago. Not sure why it's still
on the open-issues list.

It isn't. He must have an old copy:


PostgreSQL 8.0 Open Items
=========================

Current version at http://candle.pha.pa.us/cgi-bin/pgopenitems.

Changes
-------
* Win32
o add binary version stamps?
o fix signal-safe socket handler for SSL
o fix SSL compiles
o fix query cancel in psql (?)
o shorten timezone for %t log_line_prefix
o start pg_autovacuum easily
o fix users who's timezones are not recognized
o allow installed locales rather than hardcoded one
o update encoding list to include win1250
o synchonize supported encodings and docs
o disable readline-required psql options
o fix shared memory on Win2k terminal server
o fix negative getrusage() results from VACUUM VERBOSE
* fix oid2name for tablespaces
* allow libpq to check parameterized data types
* make pgxs install by default
* add xid to log_line_prefix for PITR
* cleanup FRONTEND use in /port, malloc, elog
* fix ambiguity for objects using default tablespaces
* fix case where template db already uses target tablespace
* have plpython reject pseudotype arguments because it crashes
* add i386 solaris spinlock code
* fix permissions on sequences restored via pg_dump

[Alvaro Herrera]

Post by Bruce Momjian
o fix users who's timezones are not recognized

The wording of this item is funny. How show we fix the users? Move
them to a supported location?

[Bruce Momjian]

Post by Alvaro Herrera

Post by Bruce Momjian
o fix users who's timezones are not recognized

The wording of this item is funny. How show we fix the users? Move
them to a supported location?

LOL.

OK, updated to:

o fix timezones that are are not recognized
--
Bruce Momjian | http://candle.pha.pa.us
***@candle.pha.pa.us | [phone]
+ If your life is a hard drive, | 13 Roberts Road
+ Christ can be your backup. | Newtown Square, Pennsylvania 19073

---------------------------(end of broadcast)---------------------------
TIP 3: if posting/reading through Usenet, please send an appropriate
subscribe-nomail command to ***@postgresql.org so that your
message can get through to the mailing list cleanly

[Tom Lane]

Post by Bruce Momjian
o fix timezones that are are not recognized

Is this in reference to the Windows localized-TZ-names problem?
If so, I thought that was fixed already.

regards, tom lane

---------------------------(end of broadcast)---------------------------
TIP 4: Don't 'kill -9' the postmaster

[Bruce Momjian]

Post by Tom Lane

Post by Bruce Momjian
o fix timezones that are are not recognized

Is this in reference to the Windows localized-TZ-names problem?
If so, I thought that was fixed already.

Yes, windows. I haven't seen it is fixed.

[Tom Lane]

Post by Bruce Momjian

Post by Tom Lane

Post by Bruce Momjian
o fix timezones that are are not recognized

Is this in reference to the Windows localized-TZ-names problem?
If so, I thought that was fixed already.

Yes, windows. I haven't seen it is fixed.

Magnus sent in something that fixes it for him, and I committed it:
http://developer.postgresql.org/cvsweb.cgi/pgsql-server/src/timezone/pgtz.c
revision 1.25.

(Looks ... in fact, that's the same patch we both committed last week.)

regards, tom lane

---------------------------(end of broadcast)---------------------------
TIP 8: explain analyze is your friend

[Bruce Momjian]

Post by Tom Lane

Post by Bruce Momjian

Post by Tom Lane

Post by Bruce Momjian
o fix timezones that are are not recognized

Is this in reference to the Windows localized-TZ-names problem?
If so, I thought that was fixed already.

Yes, windows. I haven't seen it is fixed.

http://developer.postgresql.org/cvsweb.cgi/pgsql-server/src/timezone/pgtz.c
revision 1.25.
(Looks ... in fact, that's the same patch we both committed last week.)

OK, removed. Should we add this URL to the developers page?

---------------------------------------------------------------------------

PostgreSQL 8.0 Open Items
=========================

Current version at http://candle.pha.pa.us/cgi-bin/pgopenitems.

Changes
-------
* Win32
o add binary version stamps?
o fix signal-safe socket handler for SSL
o fix SSL compiles
o fix query cancel in psql (?)
o shorten timezone for %t log_line_prefix
o start pg_autovacuum easily
o allow installed locales rather than hardcoded one
o update encoding list to include win1250
o synchonize supported encodings and docs
o disable readline-required psql options
o fix shared memory on Win2k terminal server
o fix negative getrusage() results from VACUUM VERBOSE
* fix oid2name for tablespaces
* allow libpq to check parameterized data types
* make pgxs install by default
* add xid to log_line_prefix for PITR
* cleanup FRONTEND use in /port, malloc, elog
* fix ambiguity for objects using default tablespaces
* fix case where template db already uses target tablespace
* have plpython reject pseudotype arguments because it crashes
* add i386 solaris spinlock code
* fix permissions on sequences restored via pg_dump

[Magnus Hagander]

Post by Bruce Momjian
PostgreSQL 8.0 Open Items
=========================
Current version at http://candle.pha.pa.us/cgi-bin/pgopenitems.
Changes
-------
* Win32

...
This one is fixed, as Tom said.

...

Post by Bruce Momjian
o fix negative getrusage() results from VACUUM VERBOSE

This one is also fixed, per
http://developer.postgresql.org/cvsweb.cgi/pgsql-server/src/port/getrusa
ge.c.diff?r1=1.6;r2=1.7.


//Magnus

---------------------------(end of broadcast)---------------------------
TIP 7: don't forget to increase your free space map settings

[Bruce Momjian]

Post by Magnus Hagander

Post by Bruce Momjian
PostgreSQL 8.0 Open Items
=========================
Current version at http://candle.pha.pa.us/cgi-bin/pgopenitems.
Changes
-------
* Win32

...
This one is fixed, as Tom said.
...

Post by Bruce Momjian
o fix negative getrusage() results from VACUUM VERBOSE

This one is also fixed, per
http://developer.postgresql.org/cvsweb.cgi/pgsql-server/src/port/getrusa
ge.c.diff?r1=1.6;r2=1.7.

Thanks. Removed.